-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(replays): Memory Chart Tooltip Overflow #38746
fix(replays): Memory Chart Tooltip Overflow #38746
Conversation
trigger: 'axis', | ||
renderMode: 'html', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the type def for the tooltips says the renderMode should be html if using appendToBody
/**
* 'auto': use html by default, and use non-html if `document` is not defined
* 'html': use html for tooltip
* 'richText': use canvas, svg, and etc. for tooltip
*/
renderMode?: 'auto' | TooltipRenderMode;
/**
* If append popup dom to document.body
* Only available when renderMode is html
*/
appendToBody?: boolean;
/**
* specified class name of tooltip dom
* Only available when renderMode is html
*/
className?: string;
```
I was poking at this for about 2mins and thought it was going to be annoying. I'm happy this is such a tidy looking solution! |
…-tooltip-overflow
…-tooltip-overflow
…-tooltip-overflow
…-tooltip-overflow
…-tooltip-overflow
@danecando update the description to match the code please |
Changes
chartId
prop to allow the tooltips to calculate position within a chart when portalled withappendToBody
Notes
Portalling the tooltips broke the styles since they were scoped to the chart container. I needed to duplicate and inject those styles in the scope of the portalled tooltip. I'm not an emotion expert so if you know a better way to accomplish that let me know
Closes #37238
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.